Merge pull request #16961 from IzzatN/change-if

collapsed conditional
emberjs · Sep 11, 2018 · 615daa2 · 615daa2
2 parents 8d84560 + b7fb321
commit 615daa2
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/@ember/-internals/glimmer/lib/components/link-to.ts b/packages/@ember/-internals/glimmer/lib/components/link-to.ts
@@ -641,10 +641,8 @@ const LinkComponent = EmberComponent.extend({
     let preventDefault = get(this, 'preventDefault');
     let targetAttribute = get(this, 'target');
 
-    if (preventDefault !== false) {
-      if (!targetAttribute || targetAttribute === '_self') {
-        event.preventDefault();
-      }
+    if (preventDefault !== false && (!targetAttribute || targetAttribute === '_self')) {
+      event.preventDefault();
     }
 
     if (get(this, 'bubbles') === false) {