[BUGFIX beta] Unguard render error tests without application template…

… wrapper
emberjs · Apr 16, 2020 · 8ede4dd · 8ede4dd
1 parent cf4a4bc
commit 8ede4dd
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 40 deletions.
diff --git a/packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js b/packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js
@@ -976,19 +976,6 @@ moduleFor(
     async ['@feature(!EMBER_ROUTING_MODEL_ARG) it emits a useful backtracking re-render assertion message'](
       assert
     ) {
-      // When application-template-wrapper optional feature is set to `false`
-      // (and therefore does not add a wrapping `<div>` for the application
-      // template) throwing during component `constructor`/`init` causes
-      // follow-on errors when the ApplicationInstance instance is destroyed
-      // (when the render roots are being cleared).
-      //
-      // TODO: remove this guard, and fix the associated failures when clearing
-      // on application instance instance destruction
-      if (!ENV._APPLICATION_TEMPLATE_WRAPPER) {
-        assert.expect(0);
-        return;
-      }
-
       this.router.map(function() {
         this.route('routeWithError');
       });
@@ -1040,19 +1027,6 @@ moduleFor(
     async ['@feature(EMBER_ROUTING_MODEL_ARG) it emits a useful backtracking re-render assertion message'](
       assert
     ) {
-      // When application-template-wrapper optional feature is set to `false`
-      // (and therefore does not add a wrapping `<div>` for the application
-      // template) throwing during component `constructor`/`init` causes
-      // follow-on errors when the ApplicationInstance instance is destroyed
-      // (when the render roots are being cleared).
-      //
-      // TODO: remove this guard, and fix the associated failures when clearing
-      // on application instance instance destruction
-      if (!ENV._APPLICATION_TEMPLATE_WRAPPER) {
-        assert.expect(0);
-        return;
-      }
-
       this.router.map(function() {
         this.route('routeWithError');
       });

diff --git a/packages/@ember/-internals/glimmer/tests/integration/mount-test.js b/packages/@ember/-internals/glimmer/tests/integration/mount-test.js
@@ -1,4 +1,3 @@
-import { ENV } from '@ember/-internals/environment';
 import {
   moduleFor,
   ApplicationTestCase,
@@ -113,19 +112,6 @@ moduleFor(
     }
 
     async ['@test it emits a useful backtracking re-render assertion message'](assert) {
-      // When application-template-wrapper optional feature is set to `false`
-      // (and therefore does not add a wrapping `<div>` for the application
-      // template) throwing during component `constructor`/`init` causes
-      // follow-on errors when the ApplicationInstance instance is destroyed
-      // (when the render roots are being cleared).
-      //
-      // TODO: remove this guard, and fix the associated failures when clearing
-      // on application instance instance destruction
-      if (!ENV._APPLICATION_TEMPLATE_WRAPPER) {
-        assert.expect(0);
-        return;
-      }
-
       this.router.map(function() {
         this.route('route-with-mount');
       });