attributeBinding for booleans broken in 2.7

[vcipriani]

In earlier versions, view attribute binding for boolean properties would have generated a tag similar to below:

<div id="ember444" bindingval="true" class="ember-view">

Now it is not displaying the attribute at all if false and doing the following if true

<div id="ember444" bindingval class="ember-view">

This can be verified by creating a brand new app and rendering a simple component setup like below.

import Ember from 'ember';

export default Ember.Component.extend({
    bindingVal: true,
    attributeBindings: ['bindingVal']
});

[pixelhandler]

@vcipriani I believe that is the desired behavior for boolean attributes in HTML, See http://www.w3.org/TR/html5/infrastructure.html#boolean-attributes

I do not believe this is a bug.

[rwjblue]

I agree with @pixelhandler. If you do want bindingval="true" you should use the string "true" or "false".

[Serabe]

Given the answers by @pixelhandler and @rwjblue, I'm closing this as not a bug. Thank you everybody!

[vcipriani]

I should have referenced this earlier, but the Ember documentation specifies the behavior we expected.

If the return value of an attributeBindings monitored property is a boolean the property's value will be set as a coerced string:

<input id="ember1" class="ember-view" disabled="false" />

Its easy enough to use a string, so I don't mind, but it seems like the docs should be updated and this should be noted as a change.

[dfreeman]

This broke a few of our tests that were using data- attributes as testing hooks — the behavior similarly changed for in-template cases like data-foo={{booleanValue}}.

The new behavior is definitely preferable (and, as @pixelhandler mentioned, correct), but it was surprising to discover, particularly since there was no mention in the changelog or release announcement.

[Serabe]

Reopening for tracking the documentation change. Thank you!

[benjaminbalazs]

Was wondering if anyone has built a patch for this to behave as it used to?

[Serabe]

No, but you can do so easily casting the boolean to a string in your function.