Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUnit Blueprints Quest Issue #15933

Closed
14 tasks done
alexander-alvarez opened this issue Dec 6, 2017 · 30 comments
Closed
14 tasks done

QUnit Blueprints Quest Issue #15933

alexander-alvarez opened this issue Dec 6, 2017 · 30 comments
Labels
Feature Help Wanted Meta

Comments

@alexander-alvarez
Copy link
Contributor

alexander-alvarez commented Dec 6, 2017 •
edited by rwjblue
Loading

Background
We need to implement changes in blueprints and docs realted to RFC 232 and RFC 268.
(Some background for those unfamiliar http://rwjblue.com/2017/10/23/ember-qunit-simplication/)

As of ember-cli-qunit@^4.1.1 (which is in the default blueprint as of [email protected]), we can implement the "Simplified QUnit" style tests in all tests except for acceptance tests.
In a future release of ember-qunit (likely 3.2.x), we will be able to leverage the implementation of setupApplicationTest from RFC 268 for use in acceptance-tests. Once these changes are implemented upstream, we must implement the blueprint updates.
Currently, we have no way to generate these test files but we can run the ember-qunit-codemod to migrate test files and continue to iterate on the final output in the blueprint specific pull requests.

The desired behavior when generating testing blueprints is to, generate "Simplified QUnit" style tests if supported by the host app. We have several tasks below to extend the blueprints to support the "Simplified QUnit" style blueprints alongside the legacy, and ember-mocha blueprints. We can likely add to the behavior of test-framework-detector.js to support this other extension. Once these changes are completed we also need to update the guides to be consistent with the current ember-cli codebase. We should work with @rwjblue and the learning team (cc @locks) to determine how we best teach this.

Tasks

To pick up one of these items, please comment below and we'll update the checklist with :lock: @your-name-here...
@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2017

Awesome, thanks for organizing this @alexander-alvarez!

@rwjblue rwjblue changed the title Qunit Blueprints Quest Issue QUnit Blueprints Quest Issue Dec 6, 2017
@Turbo87
Copy link
Member

Turbo87 commented Dec 6, 2017

@alexander-alvarez should we use qunit for the new API blueprints and something else instead of qunit for the old blueprints? this would seem more intuitive to me 🤔

@Turbo87
Copy link
Member

Turbo87 commented Dec 6, 2017

also I'm wondering if we should do the implementation in https://github.com/alexander-alvarez/ember-qunit-nested-module-blueprints-polyfill first and once those are solid we can import them here

@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2017

@Turbo87 - I'd prefer to land the "real" implementations first (so that the polyfill truly is a polyfill). If that turns out to be costly (or I'm too much of a blocker in landing PR's) we can swap to targeting the polyfill addon first...

@Turbo87 Turbo87 mentioned this issue Dec 6, 2017
Merged
@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2017

OK, first implementation is done and landed (along with the test framework detector changes required to support the path forward). The game is afoot!

@snewcomer
Copy link
Contributor

Doing the helper-test right now.

@snewcomer snewcomer mentioned this issue Dec 7, 2017
Merged
2 tasks
@RobbieTheWagner
Copy link
Member

@rwjblue I'm always happy to work on blueprints. Want to assign a couple my way?

@Turbo87
Copy link
Member

Turbo87 commented Dec 7, 2017

@rwwagner90 choose one and announce it here, so that others are not doing the same work too :)

@RobbieTheWagner
Copy link
Member

@Turbo87 I'm not picky, but I'll randomly choose route-test

@rwjblue
Copy link
Member

rwjblue commented Dec 7, 2017

Updated description:

  • 🔒 route-test for @rwwagner90
  • ✅ helper-test
  • ✅ component-test

@snewcomer
Copy link
Contributor

snewcomer commented Dec 7, 2017 •
edited
Loading

Tackling controller && initializer && instance-initializer tests in 3 separate PR's!

This was referenced Dec 7, 2017
Merged
Closed
@christophermlne
Copy link

If there's anything left I could take one.

@alexander-alvarez
Copy link
Contributor Author

alexander-alvarez commented Dec 7, 2017 •
edited
Loading

@christophermlne mixin, service, and util are still up for grabs

This was referenced Dec 7, 2017
Merged
Merged
@snewcomer
Copy link
Contributor

Taking the utils. @christophermlne lmk if you want to tackle that one or want to take on either service or mixin!

@snewcomer snewcomer mentioned this issue Dec 8, 2017
Merged
@alexander-alvarez alexander-alvarez mentioned this issue Dec 8, 2017
Merged
@boyanyordanov
Copy link
Contributor

I will try to do mixin and if I manage I will look into service as well.
I haven't contributed to ember yet so I don't know if I'll be in over my head.

@Turbo87
Copy link
Member

Turbo87 commented Dec 8, 2017

I haven't contributed to ember yet so I don't know if I'll be in over my head.

@boyanyordanov don't worry, we're here to help you if you have questions :)

@boyanyordanov boyanyordanov mentioned this issue Dec 8, 2017
Merged
@boyanyordanov
Copy link
Contributor

I'll go ahead and add a PR for service-test too.

jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. helper testing section (emberjs/ember.js#15933)
b73aa20 
This updates the testing section about helpers according to the new
Ember Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. controller section (emberjs/ember.js#15933)
d5dcc9b 
This updates the controller testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. route testing section (emberjs/ember.js#15933)
3c6f26f 
This updates the route testing section according to the new Ember QUnit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. model testing (emberjs/ember.js#15933)
10f792e 
This updates the model testing section according to the new Ember Qunit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. testing introduction (emberjs/ember.js#15933)
9311486 
This updates the introduction into testing introducing new concepts of
the Ember Qunit testing API proposed in RFC#232 and RFC#268.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): renames title of test. basics (emberjs/ember.js#15933)
bc14b90 
This updates the title of the former "Unit Testing Basics" section to
"Testing Basics" to avoid talking about "container" tests in an originally
"unit" test focused section.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): updates component section (emberjs/ember.js#15933)
f5f1438 
This updates the integration testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. helper testing section (emberjs/ember.js#15933)
be472cb 
This updates the testing section about helpers according to the new
Ember Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. controller section (emberjs/ember.js#15933)
372b308 
This updates the controller testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. route testing section (emberjs/ember.js#15933)
39d0d72 
This updates the route testing section according to the new Ember QUnit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. model testing (emberjs/ember.js#15933)
6acaf86 
This updates the model testing section according to the new Ember Qunit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. testing introduction (emberjs/ember.js#15933)
5789203 
This updates the introduction into testing introducing new concepts of
the Ember Qunit testing API proposed in RFC#232 and RFC#268.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): renames title of test. basics (emberjs/ember.js#15933)
33b9da0 
This updates the title of the former "Unit Testing Basics" section to
"Testing Basics" to avoid talking about "container" tests in an originally
"unit" test focused section.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. controller section (emberjs/ember.js#15933)
74f4be9 
This updates the controller testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. route testing section (emberjs/ember.js#15933)
ce3f0d5 
This updates the route testing section according to the new Ember QUnit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. model testing (emberjs/ember.js#15933)
e8a5c49 
This updates the model testing section according to the new Ember Qunit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): upd. testing introduction (emberjs/ember.js#15933)
a675a78 
This updates the introduction into testing introducing new concepts of
the Ember Qunit testing API proposed in RFC#232 and RFC#268.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 11, 2018
@jayjayjpg
update(testing): renames title of test. basics (emberjs/ember.js#15933)
7e0810a 
This updates the title of the former "Unit Testing Basics" section to
"Testing Basics" to avoid talking about "container" tests in an originally
"unit" test focused section.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. acc. test code examples (emberjs/ember.js#15933)
c1151a7 
This updates the acceptance testing section including its code examples
according to the new Ember Qunit Pattern proposed through RFC#268.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. unit testing section (emberjs/ember.js#15933)
5ab2bb8 
This updates the unit testing section including code examples according
to the new Ember Qunit Testing Patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): updates component section (emberjs/ember.js#15933)
0fc3073 
This updates the integration testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. helper testing section (emberjs/ember.js#15933)
0e60a81 
This updates the testing section about helpers according to the new
Ember Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. controller section (emberjs/ember.js#15933)
21a72bc 
This updates the controller testing section according to the new Ember
Qunit testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. route testing section (emberjs/ember.js#15933)
66e7721 
This updates the route testing section according to the new Ember QUnit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. model testing (emberjs/ember.js#15933)
af77ba1 
This updates the model testing section according to the new Ember Qunit
testing patterns proposed in RFC#232.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): upd. testing introduction (emberjs/ember.js#15933)
b395a9b 
This updates the introduction into testing introducing new concepts of
the Ember Qunit testing API proposed in RFC#232 and RFC#268.
jayjayjpg added a commit to jayjayjpg/guides that referenced this issue Feb 12, 2018
@jayjayjpg
update(testing): renames title of test. basics (emberjs/ember.js#15933)
dee609c 
This updates the title of the former "Unit Testing Basics" section to
"Testing Basics" to avoid talking about "container" tests in an originally
"unit" test focused section.
@rwjblue
Copy link
Member

rwjblue commented Apr 21, 2018

Thanks everyone for your hard work here!

@rwjblue rwjblue closed this as completed Apr 21, 2018
@Dhaulagiri Dhaulagiri mentioned this issue Aug 3, 2018
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Help Wanted Meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@rwjblue @Turbo87 @christophermlne @boyanyordanov @RobbieTheWagner @snewcomer @jayjayjpg @alexander-alvarez