-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Default initializer test shows globals-resolver deprecation #19046
Comments
Ya, we should update the test that is generated to add |
@rwjblue that might be a quick fix, but is it possible to change the default resolver? I think I'm getting this deprecation from a couple other places as well that I haven't traced yet. I don't know what else changing the default here might break: https://github.com/emberjs/ember.js/blob/v3.20.1/packages/@ember/engine/index.js#L455 |
No, changing the default would be a breaking change. |
The default resolver (the globals resolver is deprecated), so we always need to pass this in. Closes emberjs#19046
The default resolver (the globals resolver is deprecated), so we always need to pass this in. Closes emberjs#19046
🐞 Describe the Bug
Initializer tests logs deprecation warning for usage of
globals-resolver
.🔬 Minimal Reproduction
😕 Actual Behavior
A deprecation warning is logged
🤔 Expected Behavior
No deprecation should be logged for code the user has not written
🌍 Environment
➕ Additional Context
The problem is that
Application.create()
is called with only theautoboot: false
properties:https://github.com/emberjs/ember.js/blob/v3.20.1/blueprints/initializer-test/qunit-rfc-232-files/__root__/__testType__/__path__/__name__-test.js#L15
Since a
Resolver
from ember-resolver is not passed, the DefaultResolver is used, which is the globals resolver.Either the default should change, or the right Resolver can be imported and passed into the test application in the blueprint.
The text was updated successfully, but these errors were encountered: