[BUGFIX release] Default {{each}} key to @guid or @item based on type. #11461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
| @@ -19,8 +19,13 @@ export default function decodeEachKey(item, keyPath, index) { | |||
| if (keyPath) { | |||
| key = get(item, keyPath); | |||
| } else { | |||
| Ember.warn('Using `{{each}}` without specifying a key can lead to unusual behavior. Please specify a `key` that identifies a unique value on each item being iterated. E.g. `{{each model key="@guid" as |item|}}`.'); | |||
| key = index; | |||
| let type = typeOf(item); | |||
There was a problem hiding this comment.
yes, lets just use JS typeof here
|
Looks good 👍 |
|
yay 👍 |
|
Update:
|
|
I am +1. I've also heard many WAT about the current behavior |
rwjblue
force-pushed
the
use-default-key
branch
2 times, most recently
from
df1d4bb to
d2094bb
Compare
2 tasks
|
Updated (hopefully for the last time) to deprecate |
|
FYI: It seems that this commit didn't get into the 1.13.1 tag |
|
Thanks!! ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
@itemas the key when the item being iterated is a string or number, and uses@guidwhen it is anything else.This is an attempt at making a better default, to prevent users from having to specify a
key=to each{{each}}invocation.It is absolutely possible, that we will want to revisit this and make specifying
keyrequired in the future, but it seems that we should attempt at good defaults before making that decision.