[DOCS beta] Update Ember.deprecate and Ember.warn calls in ember-htmlbars with required options
#11840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…htmlbars with required options
ghost
changed the title
Ember.deprecate and Ember.warn calls in ember-metal with required optionshtmlbars with required optionsEmber.deprecate and Ember.warn calls in ember-htmlbars with required options
ghost
mentioned this pull request
14 tasks
| @@ -97,7 +97,7 @@ function HandlebarsCompatibleHelper(fn) { | |||
| fnResult = fn.apply(this, args); | |||
|
|
|||
| if (options.element) { | |||
| Ember.deprecate('Returning a string of attributes from a helper inside an element is deprecated.'); | |||
| Ember.deprecate('Returning a string of attributes from a helper inside an element is deprecated.', false, { id: 'ember-htmlbars.handlebars-compat-helper', until: '3.0.0' }); | |||
There was a problem hiding this comment.
Let's set this to 2.0.0, and add an issue to remove with a [CLEANUP beta] PR soon.
|
On second thought, I'm going to merge and make issues to update/tweak. |
rwjblue
added a commit
that referenced
this pull request
Jul 21, 2015
…tmlbars [DOCS beta] Update `Ember.deprecate` and `Ember.warn` calls in ember-htmlbars with required options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11835