Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove {{with}} keyword's controller option. #12001

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Aug 6, 2015

No description provided.

rwjblue added a commit that referenced this pull request Aug 6, 2015
[CLEANUP beta] Remove {{with}} keyword's controller option.
@rwjblue rwjblue merged commit 490fba7 into emberjs:master Aug 6, 2015
@rwjblue rwjblue deleted the remove-with-controller branch August 6, 2015 20:39
@mmun
Copy link
Member

mmun commented Aug 7, 2015

We should change with over to a helper now. I'm also surprised to see that with doesn't get the same shouldDisplay treatment as each/if.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 7, 2015

@mmun - It does use shouldDisplay here in the helper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants