-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component layout caching #13829
Merged
Merged
New component layout caching #13829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's failing because tildeio/broccoli-typescript-compiler#20 needs to be merged and released. |
Upstream broccoli-typescript-compiler was released as v0.6.2 |
Ok now I don't know why the blueprints are failing. I haven't been able repro locally with the same versions node and npm. |
☔ The latest upstream changes (presumably #13832) made this pull request unmergeable. Please resolve the merge conflicts. |
krisselden
force-pushed
the
new-component-layout-caching
branch
from
July 18, 2016 17:47
552fce5
to
092fd99
Compare
wycats
pushed a commit
that referenced
this pull request
Jul 29, 2016
In #13829, we introduced the ability to pass a custom key function for the cache. However, we are incorrectly passing `(key, value)` to `set` when the function expects `(obj, value)`. This is causing problems for caches that uses a custom cache keying function (such as Glimmer's compilation cache), because the get side would handle the keying correctly, but the set side would compute the key based on the already-computed key (i.e. `this.key(this.key(obj))`). In Glimmer's compilation cache, this is causing the cache to always miss because the `set` side would cache everything under the `"undefined"` key.
rwjblue
pushed a commit
that referenced
this pull request
Aug 1, 2016
In #13829, we introduced the ability to pass a custom key function for the cache. However, we are incorrectly passing `(key, value)` to `set` when the function expects `(obj, value)`. This is causing problems for caches that uses a custom cache keying function (such as Glimmer's compilation cache), because the get side would handle the keying correctly, but the set side would compute the key based on the already-computed key (i.e. `this.key(this.key(obj))`). In Glimmer's compilation cache, this is causing the cache to always miss because the `set` side would cache everything under the `"undefined"` key. (cherry picked from commit 80f0462)
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
In emberjs#13829, we introduced the ability to pass a custom key function for the cache. However, we are incorrectly passing `(key, value)` to `set` when the function expects `(obj, value)`. This is causing problems for caches that uses a custom cache keying function (such as Glimmer's compilation cache), because the get side would handle the keying correctly, but the set side would compute the key based on the already-computed key (i.e. `this.key(this.key(obj))`). In Glimmer's compilation cache, this is causing the cache to always miss because the `set` side would cache everything under the `"undefined"` key.
webark
pushed a commit
to webark/ember.js
that referenced
this pull request
Oct 6, 2016
In emberjs#13829, we introduced the ability to pass a custom key function for the cache. However, we are incorrectly passing `(key, value)` to `set` when the function expects `(obj, value)`. This is causing problems for caches that uses a custom cache keying function (such as Glimmer's compilation cache), because the get side would handle the keying correctly, but the set side would compute the key based on the already-computed key (i.e. `this.key(this.key(obj))`). In Glimmer's compilation cache, this is causing the cache to always miss because the `set` side would cache everything under the `"undefined"` key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on this landing glimmerjs/glimmer-vm#217