[CLEANUP beta] Fix ember-2-legacy support for Ember.Binding. #16095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary change here is to allow `Ember.Mixin.finishPartial` and `Ember.Mixin.detectBinding` to be undefined/null. The reason for this is that there is an annoying ordering issue. Basically, the environment flags are present from when Ember itself boots, but the monkey patches added by ember-2-legacy (`detectBinding` and `finishPartial`) are not done until _after_ the main `ember.debug.js` / `ember.prod.js` files have been processed. _Within_ the evaluation of the main `ember.*.js` file, the environment variable has been set but these functions are still missing. This means that _Ember itself_ (during evaluation of `Ember.CoreObject`) causes an issue when it attempts to call `Mixin.finishPartials`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change here is to allow
Ember.Mixin.finishPartialandEmber.Mixin.detectBindingto be undefined/null. The reason for this is that there is an annoying ordering issue. Basically, the environment flags are present from when Ember itself boots, but the monkey patches added by ember-2-legacy (detectBindingandfinishPartial) are not done until after the mainember.debug.js/ember.prod.jsfiles have been processed. Within the evaluation of the mainember.*.jsfile, the environment variable has been set but these functions are still missing. This means that Ember itself (during evaluation ofEmber.CoreObject) causes an issue when it attempts to callMixin.finishPartials.