Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Mention "computed properties" in the assertion message #16199

Merged
merged 3 commits into from
Feb 2, 2018
Merged

[BUGFIX beta] Mention "computed properties" in the assertion message #16199

merged 3 commits into from
Feb 2, 2018

Conversation

chancancode
Copy link
Member

@chancancode chancancode changed the title [BUGFIX beta] Use "computed properties" in the msg [BUGFIX beta] Mention "computed properties" in the assertion message Jan 30, 2018
@rwjblue
Copy link
Member

rwjblue commented Jan 30, 2018

Has a failing test (that is checking the assertion message)...

@rwjblue
Copy link
Member

rwjblue commented Feb 1, 2018

ping @chancancode

@chancancode
Copy link
Member Author

Fixed it!

@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2018

@chancancode - Nope, apparently didn't work:

Test failed: computed: accessing computed property descriptor through the object triggers an assertion
    Failed assertion: Expected failing Ember.assert: '/You attempted to access `foo\.isDescriptor` \(on `obj`\)\./', but got 'You attempted to access `foo.isDescriptor` (of `obj`), but `foo` is a computed property.

@chancancode
Copy link
Member Author

🤞

@rwjblue rwjblue merged commit bd61fc8 into beta Feb 2, 2018
@rwjblue rwjblue deleted the chancancode-patch-1 branch February 2, 2018 15:14
@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2018

👏

chancancode pushed a commit that referenced this pull request Feb 3, 2018
@rwjblue @chancancode
Merge pull request #16199 from emberjs/chancancode-patch-1
691259c 
[BUGFIX beta] Mention "computed properties" in the assertion message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chancancode @rwjblue