[BUGFIX beta] Ensure proper .toString() of default components. #16307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older Ember versions the default components were generally labelled as
Ember.Component
orEmber.TextField
via theNAME_KEY
property on the class itself. During the glimmer-vm upgrade which landed during the 3.1 canary cycle the customNAME_KEY
was lost forEmber.TextField
.This commit removes needless usage of
NAME_KEY
(not needed since our normalEmber.Object
instance's.toString
methods check for the factories owntoString
properly), and updates the actual paths to match the new JS modules API locations (thus reducing more "globals" shenanigans).