[BUGFIX release] fix mouseEnter/Leave event delegation w/o jQuery #16999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since #16603 was landed in 3.4 (current release and LTS candidate), we need to update this to |
The previous implementation did not work correctly when the element of the component listening to mouseEnter/Leave was quickly moved over, (i.e. no mouseover event triggered on this element) and the child node is from another component, as demonstrated in the replication in emberjs#16922. Related to 16603 Fixes emberjs#16922
simonihmig
force-pushed
the
fix-eventdelegation-nojquery
branch
from
8277811 to
6264318
Compare
simonihmig
changed the title
|
@rwjblue sure. I updated the commit message. Targeting the master branch is still correct, right? |
|
Yep! |
rwjblue
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation did not work correctly when the element of
the component listening to mouseEnter/Leave was quickly moved over,
(i.e. no mouseover event triggered on this element) and the child node
is from another component, as demonstrated in the replication in #16922.
Added better test coverage, with better replication how mouseover/out events fire in reality. The last added tests was the one that catched the misbehaviour.
Related to #16603
Fixes #16922