[BUGFIX beta] Update to glimmer-vm 0.37.1. #17499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
approved these changes
Jan 22, 2019
rwjblue
force-pushed
the
patch-glimmer-vm
branch
from
d0c04d1 to
b807746
Compare
Fixes a few issues: * Usage of positional arguments with custom components. * Forwarding attributes via `...attributes` to a dynamic component. * Prevent errors when rendering many template blocks (`Error: Operand over 16-bits. Got 65536`). Full changes here: glimmerjs/glimmer-vm@v0.37.0...v0.37.1
…nent invoked with angle-bracket syntax that receives splattributes (cherry picked from commit 2d1f8d0)
…warded. (cherry picked from commit 4073c1a)
…anagers (cherry picked from commit 5639352)
rwjblue
force-pushed
the
patch-glimmer-vm
branch
from
b807746 to
9ce961a
Compare
rwjblue
changed the title
|
FYI - These changes landed in:
|
This was referenced Jan 22, 2019
|
Yay, dynamic component splattributes! Thanks, @rwjblue! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues:
...attributesto a dynamiccomponent.
(
Error: Operand over 16-bits. Got 65536).Full changes here:
glimmerjs/glimmer-vm@v0.37.0...v0.37.1
Closes #17146
Closes #17160
Closes #17483