Initializer blueprint: remove setupTest() #17713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Mar 7, 2019
|
It's weird, as the failing test for all my open blueprint PRs is Hm, I'll look into this later! |
|
Was also failing on master, for a different blueprint-related merge commit: https://travis-ci.org/emberjs/ember.js/jobs/502674925 🤔 |
|
Ah, wait! This should fix it: #17716, was just merged hours ago, so I hopefully just need to rebase! |
As it is not needed, see emberjs#17411 (comment)
simonihmig
force-pushed
the
blueprint-qunit-init
branch
from
6bf3bf3 to
a9d71d0
Compare
|
Indeed green now, same for the other 3 PRs! @rwjblue your turn again! 😉 |
|
Thank you, sorry for the run around here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is not needed, see #17411 (comment)