-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotracking Bugfix: Make the model property on the controller tracked #18074
Autotracking Bugfix: Make the model property on the controller tracked #18074
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
@pzuraq - Any objections?
packages/ember/tests/routing/route_controller_integration_test.js
Outdated
Show resolved
Hide resolved
C.I. error:
:( |
I'm not sure exactly why this is an issue, but regenerator-runtime is throwing that error. Specifically, it doesn't like the inline class declarations within the test function. There are two "easy" choices:
|
is it worth configuring the tests to support async/await? |
They do support async / await in general, @pzuraq recently added that. The specific issue in this case is that (apparently) regenerator-runtime doesn't know what to do with a |
5105a48
to
9487bd7
Compare
@NullVoxPopuli - Can you squash? |
9487bd7
to
cd26304
Compare
squashed |
idk what's up with the git history here... |
cd26304
to
58efd76
Compare
CHANGELOG.md
Outdated
@@ -16,6 +16,10 @@ | |||
- [#17940](https://github.com/emberjs/ember.js/pull/17940) [CLEANUP] Remove `sync` queue from @ember/runloop. | |||
- [#18026](https://github.com/emberjs/ember.js/pull/18026) Enabling featured discussed in 2019-05-03 core team meeting. | |||
|
|||
### v3.10.1 (June 4, 2019) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did this come from O.o
@rwjblue fixed history ™️ :) |
looks like browserstack had a problem |
can someone click re-run? |
58efd76
to
f2d49c7
Compare
TODO:write failing testadd tracked when auto-tracking is enabledwhen the tracked flag is enabled, the controller's model property will be tracked by default.