[BUGFIX lts] ember-template-compiler & fastboot compatibility #18080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When importing ember-template-compiler as part of the dist bundle, it's initializer for DOM Templates
comes along as well.
While this would normally just be extra bytes for no reason when used in conjunction with FastBoot.
It throws a
document is undefined error
within the bootstrap module.Patch
If no context is passed to the bootstrap module it throws the aforementioned error, The initializer does check if the current context has a dom but just uses it to set up the context, but a dom instance would not have existed when entering the bootstrap module.
For this, my patch solution would be to only call the bootstrap if a document instance is present.
Moving forward
I would love to get some thoughts on the future of the bootstrap module and this initializer :).