[DOC] Document get helper array element access with second arg of type number #19871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue, tagging you for visibility 🙂 |
rwjblue
approved these changes
Jan 12, 2022
jamescdavis
deleted the
document_get_helper_array_element_access_with_number
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the docs for the
gethelper to indicate that the 2nd argument can be a number. This has been supported since Ember 2.14 and was added in #15366 (along with a test to make sure it continues to work). This test still exists in Ember 4.I've also updated the docs to indicate that the
gethelper can be used for array element access via index with a second dynamic arg that has a numeric value. #15667 fixed and added a test specifically for array element access via numeric index, which is still present, and #16218 fixed this for a const number second arg and added a test specifically for array index access via a const number, which is also still present.