-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX LTS 4.4] Don't run getters while applying mixins #20405
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
packages/@ember/-internals/runtime/tests/mixins/accessor_test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import EmberObject from '@ember/object'; | ||
| import { moduleFor, RenderingTestCase } from 'internal-test-helpers'; | ||
|
|
||
| moduleFor( | ||
| 'runtime: Mixin Accessors', | ||
| class extends RenderingTestCase { | ||
| ['@test works with getters'](assert) { | ||
| let value = 'building'; | ||
|
|
||
| let Base = EmberObject.extend({ | ||
| get foo() { | ||
| if (value === 'building') { | ||
| throw Error('base should not be called yet'); | ||
| } | ||
|
|
||
| return "base's foo"; | ||
| }, | ||
| }); | ||
|
|
||
| // force Base to be finalized so its properties will contain `foo` | ||
| Base.proto(); | ||
|
|
||
| class Child extends Base { | ||
| get foo() { | ||
| if (value === 'building') { | ||
| throw Error('child should not be called yet'); | ||
| } | ||
|
|
||
| return "child's foo"; | ||
| } | ||
| } | ||
|
|
||
| Child.proto(); | ||
|
|
||
| let Grandchild = Child.extend({ | ||
| get foo() { | ||
| if (value === 'building') { | ||
| throw Error('grandchild should not be called yet'); | ||
| } | ||
|
|
||
| return value; | ||
| }, | ||
| }); | ||
|
|
||
| let instance = Grandchild.create(); | ||
|
|
||
| value = 'done building'; | ||
|
|
||
| assert.equal(instance.foo, 'done building', 'getter defined correctly'); | ||
|
|
||
| value = 'changed value'; | ||
|
|
||
| assert.equal(instance.foo, 'changed value', 'the value is a real getter, not a snapshot'); | ||
| } | ||
| } | ||
| ); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we can bump this in a point release since it would be a breaking change that would be very unexpected. Bumping the version for a particular CI job should be fine though I am curious why it failed: theoretically the smoke test should work on 4.4 without changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the rule about releases that each release supports whatever node version is still under maintenance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed on discord, but writing here as well: I think a node version bump in a patch release would be very surprising to users. The policy states only when we drop support on the primary branch of ember-cli https://github.com/ember-cli/ember-cli/blob/master/docs/node-support.md