-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate array prototype extensions #20702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonihmig
force-pushed
the
array-prototype-deprecation
branch
3 times, most recently
from
June 5, 2024 19:12
fafcfba
to
7981199
Compare
simonihmig
force-pushed
the
array-prototype-deprecation
branch
from
June 5, 2024 19:14
7981199
to
d06a63b
Compare
simonihmig
force-pushed
the
array-prototype-deprecation
branch
from
June 5, 2024 19:20
d06a63b
to
09dc249
Compare
simonihmig
commented
Jun 5, 2024
@@ -129,6 +129,16 @@ export const DEPRECATIONS = { | |||
enabled: '5.10.0', | |||
}, | |||
}), | |||
DEPRECATE_ARRAY_PROTOTYPE_EXTENSIONS: deprecation({ | |||
id: 'deprecate-array-prototype-extensions', | |||
url: 'https://deprecations.emberjs.com/id/deprecate-deprecate-array-prototype-extensions', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This points to ember-learn/deprecation-app#1192, which we also need to get merged.
Thanks @simonihmig. We should backport this beta. |
12 tasks
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC848.
This was a bit trickier than I actually expected, here is what I did and failed to do:
EmberENV.EXTEND_PROTOTYPES
is not false. But given that there is some data munging happening here that is turningEXTEND_PROTOTYPES: false
to becomeEXTEND_PROTOTYPES: { Array: false }
, which I was not eager to change, the deprecation is skipped for both of these. I think that is ok?EXTEND_PROTOTYPES
config is evaluated (1st commit)deprecations/index.ts
, so I moved the deprecation call to the latter. Not ideal, but I had no better idea. (2nd commit)expectDeprecation
. Any idea how to add a test here?expectDeprecation
, I addedRAISE_ON_DEPRECATION=false
to the test matrix scenarios that haveEXTEND_PROTOTYPES
to make them be able to actually run. (3rd commit)