Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade glimmer-vm #20842

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Feb 7, 2025

Replaces: #20801

Most of what's in these VM changes is prep for bigger bugfixes and improvements (especially to debug tooling / inspector stuff).

The timing of this PR is early, as we don't want a big VM upgrade all at once.
Every change has gone through performance testing, and found either no regression, or slight improvement.

Changelog: glimmerjs/glimmer-vm#1626

Updates:

  • Code supporting partials has been removed
  • Better debug symbols in strict-mode

notes:

long ago, I made https://github.com/NullVoxPopuli/tsc-lite because tsc does not the wrong thing by hiding your most important errors at the top of the buffer (and sometimes you have enough errors that it surpasses your max-buffer, so you can't scroll to the most important error). tsc-lite shows only the first few chunks of the tsc output, so you can focus on what to fix first, in the proper order.

This has come in handy here, as we broke the types in glimmer-vm (they need to be rolled up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant