Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #20801
Most of what's in these VM changes is prep for bigger bugfixes and improvements (especially to debug tooling / inspector stuff).
The timing of this PR is early, as we don't want a big VM upgrade all at once.
Every change has gone through performance testing, and found either no regression, or slight improvement.
Changelog: glimmerjs/glimmer-vm#1626
Updates:
notes:
long ago, I made https://github.com/NullVoxPopuli/tsc-lite because
tsc
does not the wrong thing by hiding your most important errors at the top of the buffer (and sometimes you have enough errors that it surpasses your max-buffer, so you can't scroll to the most important error). tsc-lite shows only the first few chunks of the tsc output, so you can focus on what to fix first, in the proper order.This has come in handy here, as we broke the types in glimmer-vm (they need to be rolled up).