Refresh href in linkTo when one of the params changes #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Implementation method aside, 👍 on fixing unbound href in |
|
Awesome! |
Closed
|
@wycats this is a simpler version of #2252, do you think this could be merged as a start of making |
|
+1 looks like I just came across this very issue http://stackoverflow.com/questions/15443156/when-my-computed-property-is-updated-the-linkto-attr-does-not-get-update-in-embe/15449439 |
ghost
assigned 
machty
added a commit
to machty/ember.js
that referenced
this pull request
Jul 2, 2013
Merge of work between @drogus and @machty. Replaces and Closes emberjs#2181 Replaces and Closes emberjs#2252 {{linkTo}} contexts are now bound. e.g.: {{linkTo 'foo' pathToObj}} will generate a linkTo that updates its href if the resolved value of `pathToObj` changes. Also, if ANY of the linkTo params yield null/undefined, including the first route name param (if it is unquoted), href will be '#', a new `loadingClass` class will be applied to the linkTo element, and clicking/invoking the loading linkTo will no-op and produce an Ember.Logger.warn message that the linkTo isn't loaded yet. Note: due to overlap in loading logic and the recently added stringified linkTo route behavior, the loading logic is hidden behind the ENV.HELPER_PARAM_LOOKUPS flag for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
linkTohelper is unbound when it comes to href attribute, which may be really annoying, because suddenly your pretty templates start to be full of{{#with}}helpers over everylinkTo, which has the object that potentially can change.This can be fixed rather easily by refreshing
hrefattribute when one of the params changes.This will of course not handle the case when the actual attribute, like an
id, changes, but it will help in most cases. Most of the time you useidand most of the timeiddoes not change.