Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename computed array macros to match #3158 #3227

Merged
merged 1 commit into from
Aug 30, 2013

Conversation

mmun
Copy link
Member

@mmun mmun commented Aug 28, 2013

Renamed Ember.computed.mapProperty/Ember.computed.filterProperty to Ember.computed.mapBy/Ember.computed.filterBy and added deprecations.

@cibernox
Copy link
Contributor

I think that mapProperty and filterProperty should remain as is.
At least for me the name mapByProperty seems that will return an array with the objects instead of an array with the properties.
And filterByProperty is even more confusing to me.

@hjdivad
Copy link
Member

hjdivad commented Aug 29, 2013

Consistency is a virtue. mapBy is what's on Ember.Enumerable so it's the right thing for the array computed macros.

Thanks for cleaning this up @mmun. ^_^

wagenet added a commit that referenced this pull request Aug 30, 2013
@wagenet wagenet merged commit 23886ef into emberjs:master Aug 30, 2013
@mmun mmun deleted the rename-array-macros branch December 8, 2014 17:18
duggiefresh added a commit to duggiefresh/ember.js that referenced this pull request Jul 1, 2015
rwjblue pushed a commit that referenced this pull request Jul 5, 2015
Deprecated since '13. See: #3227

(cherry picked from commit be966d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants