Update examples to 1.13.x standards #536
Conversation
* No Ember.View * No Ember.keys
| self.get('attributeBindings').pushObject(key); | ||
| export default Ember.Component.reopen({ | ||
| bindAttributes: Ember.on('init', function() { | ||
| Object.keys(this).forEach((key) => { |
There was a problem hiding this comment.
I am too. Which seems like that might be a problem. I get a deprecation warning if I use Ember.keys with 1.13.x, and others are removing it (emberjs/ember-test-helpers#71), so seemed right? Unsure.
There was a problem hiding this comment.
@typeoneerror according to the documentation "On browsers that support it, this uses the native Object.keys implementation." so I think you are right. I thought maybe it did something with computed properties or the like.
There was a problem hiding this comment.
@locks the open PR has been reverted back to Ember.keys. see: https://twitter.com/trek/status/628305995589152768.
There was a problem hiding this comment.
👍 thank you for the clarification
|
I could swear a previous PR removed all mentions of |
|
Still there in master:
I'll move the PR to master. |
Example more es6-y.