Deprecate Globals Resolver #331

Gaurav0 · 2018-05-08T16:57:33Z

rwjblue

Definitely in favor of this, thanks for writing it up!

rwjblue · 2018-05-10T14:16:08Z

text/0000-deprecate-globals-resolver.md

+
+# Transition Path
+
+Primarily, the transition path is to recommend using Ember-CLI.


Not sure anything needs to change here per-se, but using Ember without ember-cli is already officially not supported.

I know. I mainly wrote this up so we could get some deprecation warnings set up.

rwjblue

We discussed this RFC during the Ember.js Core Team meeting today, and are moving it into the final comment period.

rwjblue · 2018-06-01T20:40:33Z

text/0000-deprecate-globals-resolver.md

+# Unresolved questions
+
+There has never been a transition guide for transitioning an old codebase to Ember-CLI.
+Do we want to create one at this late date?


I think that we certainly could do it, but I don't think that it would be a requirement for moving forward with this RFC. As it stands today, the migration path away from globals mode to a more natural ember-cli built application is something most of our community has already absorbed, and the effort of writing a thorough migration guide at this point far outweighs the upside...

I think a traditional approach to deprecation RFCs is that we write the deprecation documentation here in the RFC. Once we pick a deprecation strategy I'd like to see that added.

I would appreciate it if anyone can PR some documentation against this RFC.

I'm really not sure what to say except "Do not use globals resolver, use ember-cli".

@Gaurav0 put together a summary for the deprecation guide over in ember-learn/deprecation-app#153

rwjblue · 2018-06-01T20:43:41Z

text/0000-deprecate-globals-resolver.md

+
+# Transition Path
+
+Primarily, the transition path is to recommend using Ember-CLI.


One small clarifying point for this transition path, is that ember-cli's own default resolver ember-resolver currently still extends from the globals resolver. In order to implement this RFC, and deprecate the globals resolver we need to change the ember-cli resolver so that it does not extend from the globals resolver (otherwise even ember-cli users would get a deprecation).

Comment added

JackEllis · 2018-06-15T13:08:10Z

I've never used this.

andyhot · 2018-06-19T23:19:17Z

Will the global resolver be moved to its own repo (once it's deprecated from ember)?

rwjblue · 2018-06-19T23:21:57Z

This RFC does not propose that, but it definitely seems possible if someone does like it / want it.

Gaurav0 · 2018-06-20T02:33:45Z

@andyhot Are you using the globals resolver? How can we best help you transition?

mixonic

Thanks for pushing this forward @Gaurav0! I'm excited to see this cleanup happen.

mixonic · 2018-06-26T16:29:06Z

text/0000-deprecate-globals-resolver.md

+currently still extends from the globals resolver.
+In order to implement this RFC, the ember-cli resolver will need to be changed
+so that it does *not* extend from the globals resolver, or otherwise ember-cli users
+will get a deprecation warning as well.


We can't remove the global resolver base class for the ember-cli classic resolver, that would be a breaking change.

I can think of two options:

Simple option

Have the global resolver log a deprecation message at runtime. When resolve or any other method on the global resolver is hit, deprecation message. Then we remove a) the global resolver and b) ember-cli classic resolver's extension in 4.0.

Complex, faster option

In the ember-cli classic resolver, deprecate any runtime calls where there is fallback to the globals mode resolver. This would be a deprecation in ember-cli's resolver. We could bump a major version of ember-cli-resolver removing the base class and release it in ember-cli after an LTS of ember-cli.

Then separately (or concurrently with some cleverness) we could deprecate any use of the ember-cli globals resolver.

In the ember-cli classic resolver, deprecate any runtime calls where there is fallback to the globals mode resolver. This would be a deprecation in ember-cli's resolver. We could bump a major version of ember-cli-resolver removing the base class and release it in ember-cli after an LTS of ember-cli.

This was what I was planning on doing.

Unless there are any objections, I'll put this in the RFC?

Yes, sounds good to update with that.

mixonic · 2018-06-26T16:32:58Z

text/0000-deprecate-globals-resolver.md

+
+Over the past years we have transitioned to using Ember-CLI as the main way
+to compile Ember apps. The globals resolver is a holdover and primarily
+facilitates use of Ember without Ember-CLI.


I did a quick review, and it does look like the ember-cli classic resolver replaces all methods on the globals resolver 👍

mixonic · 2018-06-26T16:34:53Z

text/0000-deprecate-globals-resolver.md

+# Unresolved questions
+
+There has never been a transition guide for transitioning an old codebase to Ember-CLI.
+Do we want to create one at this late date?


I think a traditional approach to deprecation RFCs is that we write the deprecation documentation here in the RFC. Once we pick a deprecation strategy I'd like to see that added.

Gaurav0

@mixonic Thank you for your feedback.

Gaurav0 · 2018-06-27T14:31:57Z

text/0000-deprecate-globals-resolver.md

+
+# Transition Path
+
+Primarily, the transition path is to recommend using Ember-CLI.


Comment added

Gaurav0 · 2018-06-27T14:32:36Z

text/0000-deprecate-globals-resolver.md

+currently still extends from the globals resolver.
+In order to implement this RFC, the ember-cli resolver will need to be changed
+so that it does *not* extend from the globals resolver, or otherwise ember-cli users
+will get a deprecation warning as well.


Unless there are any objections, I'll put this in the RFC?

Gaurav0 · 2018-06-27T14:33:52Z

text/0000-deprecate-globals-resolver.md

+# Unresolved questions
+
+There has never been a transition guide for transitioning an old codebase to Ember-CLI.
+Do we want to create one at this late date?


I would appreciate it if anyone can PR some documentation against this RFC.

I'm really not sure what to say except "Do not use globals resolver, use ember-cli".

ming-codes · 2018-07-01T07:17:45Z

I think global resolver is still needed for the case where you can start using Ember by linking in via script tag. This was one of the selling point of Vue.

I didn’t know this is still possible before I read this rfc.

mehulkar · 2018-07-03T08:32:35Z

I've actually been looking forward to migrating a legacy app to Ember by way of the globals resolver (would be a nice onboarding strategy instead of doing a full rewrite). But that said, I can pretty trivially start with an older version of Ember to accomplish this.

rtablada · 2018-07-03T15:40:29Z

@mehulkar are you looking to migrate a legacy Ember app or a server rendered site over to Ember? You can still use Ember to replace page by page without global resolver.

ef4 · 2018-07-03T15:56:55Z

I didn’t know this is still possible before I read this rfc.

For practical purposes, it's not. It's documented nowhere, it supports almost nothing you would want to add to your app, and we already dropped support for anyone not building with ember-cli back at 3.0.

If somebody wants to do a project to make a pleasant "try Ember with zero install" setup, that would be great. It's definitely doable (and Ember Twiddle already demonstrates most of what you'd need to get working). But it would not use the globals resolver, which -- far from being a nice selling point for Ember -- is part of the crufty history that we want to get rid of precisely because it makes adoption and innovation harder.

A nice Try Ember experience deserves to be designed for that purpose. The globals resolver is not it.

Gaurav0 · 2018-07-11T20:01:33Z

I drafted a deprecation guide here: ember-learn/deprecation-app#155

mixonic · 2018-07-12T17:19:57Z

@Gaurav0 thanks for the deprecation draft.

FWIW, I think 90% of users who will run into this are not legacy non-ember-cli users. I believe we got those users to upgrade already. I believe it will be users of Ember-CLI who are using App.MyModel = and other globals items sprinkled through their otherwise modern codebase. Thus I think you could more simply tell people to "don't use App.FooBarComponent for example, instead create a file with the appropriate name per Ember documentation: app/components/foo-bar.js.

@Gaurav0 can you update your RFC to include a link to the deprecation guide draft? Thank you.

I expect we will FCP this on Friday and merge it next week!

mehulkar · 2018-07-12T18:06:55Z

@rtablada it would have been a non-ember app. I would have tried to use it in exactly the way documented in this RFC (i.e. stick some script tags into my html that creates and renders an app in a specific div). There's no reason that I need to use latest Ember to try this out though.

Gaurav0 · 2018-07-12T18:41:58Z

@mixonic Do you want a link to the pull request (https://github.com/Gaurav0/deprecation-app/blob/deprecation_guide_globals_resolver/content/ember/v3/deprecate-globals-resolver.md) or to where it will end up (https://emberjs.com/deprecations/v3.x#toc_ember-deprecate-globals-resolver) once merged and published?

mixonic · 2018-07-12T18:47:42Z

@Gaurav0 to the pull request would be great. The idea is that someone reviewing the RFC should be able to read the proposed deprecation guidance either in the RFC itself or wherever it is elsewhere.

Thank you!

Gaurav0 · 2018-08-02T20:42:36Z

FWIW, I think 90% of users who will run into this are not legacy non-ember-cli users. I believe we got those users to upgrade already. I believe it will be users of Ember-CLI who are using App.MyModel = and other globals items sprinkled through their otherwise modern codebase. Thus I think you could more simply tell people to "don't use App.FooBarComponent for example, instead create a file with the appropriate name per Ember documentation: app/components/foo-bar.js.

@mixonic I haven't run into this. In fact, most people don't know what the global namespace is for their app. Unless I made a mistake trying this, it doesn't work by default, even if they have a global namespace via https://github.com/ember-cli/ember-export-application-global and have enabled it in production mode. The ember-cli resolver takes over. Maybe one can get it working, but I'm not sure how.

rwjblue · 2018-08-31T21:55:08Z

Discussed with the core team again today, and we are 👍 on moving this back into final comment period.

rwjblue · 2018-09-07T19:09:28Z

👏 lets do it!

tomdale · 2018-09-07T20:53:25Z

Thank you @Gaurav0, and congrats on the merged RFC!

* master: (56 commits) Fix code examples & add ember-cli release version in emberjs#637 Update FCP guidance to include Discord Update RFC 085421 ready-for-release PR URL Advance RFC {{ inputs.rfc-number }} to Stage ready-for-release feat: EmberData Cache v2.1 finalize lifetimes Update text/0860-ember-data-request-service.md Update RFC 496, typos, correct field name add note chore: update RequestService url with finalized design details Move emberjs#331 deprecate-globals-resolver to recommended Correct metadata for emberjs#487 custom model classes Move emberjs#625 helper-managers to recommended Add release date and version for 776 Update RFC 0776 released PR URL Advance RFC {{ inputs.rfc-number }} to Stage released Update RFC 0739 ready-for-release PR URL Advance RFC {{ inputs.rfc-number }} to Stage ready-for-release Deprecate `ember-mocha` Add title of RFC to advancement PR titles ...

Deprecate globals resolver

69003d6

Gaurav0 changed the title ~~Deprecate globals resolver~~ Deprecate Globals esolver May 8, 2018

Gaurav0 changed the title ~~Deprecate Globals esolver~~ Deprecate Globals Resolver May 8, 2018

Remove 'obvious necessity' comment

b26937c

rwjblue reviewed May 10, 2018

View reviewed changes

Gaurav0 force-pushed the deprecate_globals_resolver branch 2 times, most recently from 3e78b7a to 50130c7 Compare May 10, 2018 20:25

Add an explanation of what the globals resolver is

4d1c024

Gaurav0 force-pushed the deprecate_globals_resolver branch from 50130c7 to 4d1c024 Compare May 10, 2018 20:25

rwjblue approved these changes Jun 1, 2018

View reviewed changes

rwjblue added the Final Comment Period label Jun 1, 2018

Incorporate rwjblue's comment regarding ember-resolver

bff2655

jayjayjpg mentioned this pull request Jun 4, 2018

Release Ember.js Times Issue #50 emberjs/website#3373

Merged

rwjblue self-assigned this Jun 8, 2018

mixonic reviewed Jun 26, 2018

View reviewed changes

mixonic removed the Final Comment Period label Jun 26, 2018

Gaurav0 commented Jun 27, 2018

View reviewed changes

Gaurav0 mentioned this pull request Jun 28, 2018

Deprecation guide for Deprecate Globals Resolver RFC ember-learn/deprecation-app#153

Closed

Expand on implementation details

3f37324

Gaurav0 added 2 commits July 12, 2018 14:53

add link to deprecation guide pr

0dfb13c

rename file

5a22508

rwjblue added the Final Comment Period label Aug 31, 2018

rwjblue merged commit a93e20a into emberjs:master Sep 7, 2018

kategengler mentioned this pull request Feb 12, 2019

RFC #0331 - Tracking for Deprecate Globals Resolver emberjs/rfc-tracking#20

Closed

3 tasks

chancancode mentioned this pull request Jun 21, 2022

Application class: convert docs to ES6 syntax emberjs/ember.js#20113

Merged

wagenet added a commit that referenced this pull request Mar 13, 2023

Move #331 deprecate-globals-resolver to recommended

ecaed51


		# Transition Path

		Primarily, the transition path is to recommend using Ember-CLI.

Deprecate Globals Resolver #331

Deprecate Globals Resolver #331

Conversation

Gaurav0 commented May 8, 2018 • edited Loading

rwjblue left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwjblue left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JackEllis commented Jun 15, 2018

andyhot commented Jun 19, 2018

rwjblue commented Jun 19, 2018

Gaurav0 commented Jun 20, 2018

mixonic left a comment

Choose a reason for hiding this comment

mixonic Jun 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gaurav0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ming-codes commented Jul 1, 2018

mehulkar commented Jul 3, 2018

rtablada commented Jul 3, 2018

ef4 commented Jul 3, 2018

Gaurav0 commented Jul 11, 2018

mixonic commented Jul 12, 2018

mehulkar commented Jul 12, 2018

Gaurav0 commented Jul 12, 2018

mixonic commented Jul 12, 2018

Gaurav0 commented Aug 2, 2018

rwjblue commented Aug 31, 2018

rwjblue commented Sep 7, 2018

tomdale commented Sep 7, 2018

Gaurav0 commented May 8, 2018 •

edited

Loading

mixonic Jun 26, 2018 •

edited

Loading