Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code examples & add ember-cli release version in emberjs/rfcs#637 #930

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix code examples & add ember-cli release version in emberjs/rfcs#637 #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions text/0637-customizable-test-setups.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ start-date: 2020-06-01T00:00:00.000Z
release-date: 2020-05-02T00:00:00.000Z
release-versions:
ember-source: v4.4.0
# ember-cli: FIXME
ember-cli: v4.3.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in ember-cli/ember-cli#9803 and included in ember new as of 4.3.0 ember-cli/ember-new-output@25b18e0.


teams:
- framework
Expand Down Expand Up @@ -50,7 +50,7 @@ For example:

```js
import { module, test } from 'qunit';
import setupTest from 'ember-qunit';
import { setupTest } from 'ember-qunit';

module('Unit | Service | tomster', function(hooks) {
setupTest(hooks);
Expand All @@ -64,7 +64,7 @@ manually be changed to:

```js
import { module, test } from 'qunit';
import setupTest from 'my-app/tests/helpers';
import { setupTest } from 'my-app/tests/helpers';

module('Unit | Service | tomster', function(hooks) {
setupTest(hooks);
Expand All @@ -77,8 +77,8 @@ or where the setup functions are to be composed, this must be added:

```js
import { module, test } from 'qunit';
import setupTest from 'ember-qunit';
import setupMyTest from 'my-app/tests/helpers';
import { setupTest } from 'ember-qunit';
import { setupMyTest } from 'my-app/tests/helpers';

module('Unit | Service | tomster', function(hooks) {
setupTest(hooks);
Expand Down