-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Converts "Logos" page into "Brand Guidelines," updates assets #3381
Conversation
- Added "register" language - Made entire banner clickable - Misc. restyling
Web guidelines work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So excited to ship this!
Annnd... don't merge just yet :p I want @MelSumner to take a look but also @jeffdaley is going to add a commit with some tweaks we discussed. |
Tertiary logos added to the Guidelines screen and PDF. One thing I couldn't figure out is how to change the footer link from "Logos" to "Brand Guidelines." My change in the Also, should we change the file and url from |
source/_header.html.erb
Outdated
@@ -55,30 +55,30 @@ | |||
<li role="separator" class="divider"></li> %> | |||
<li><a href="/team">The Team</a></li> | |||
<li role="separator" class="divider"></li> | |||
<li><a href="/logos">Logos</a></li> | |||
<li><a href="/logos">Brand Guidelines</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking, maybe pedantic- "Branding" instead of "Brand Guidelines" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that. Especially since we have "community guidelines."
@jeffdaley the footer changes aren't showing up because the footer is coming from ember-styleguide - @locks can you confirm? |
The middleman parts of the website in this repo uses https://github.com/ember-learn/glimmer-styleguide. Everything else uses https://github.com/ember-learn/ember-styleguide |
What it does
Related Issue(s)
Sources