Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Converts "Logos" page into "Brand Guidelines," updates assets #3381

Merged
merged 16 commits into from
Jun 4, 2018
Merged

Converts "Logos" page into "Brand Guidelines," updates assets #3381

merged 16 commits into from
Jun 4, 2018

Conversation

jeffdaley
Copy link
Contributor

What it does

  • Converts the "logos" page into "brand guidelines"
  • Updates the logo asset files
  • Adds link to new brand guidelines pdf

Related Issue(s)

Sources

2018-06-01 15 11 36

@wifelette wifelette requested a review from MelSumner June 1, 2018 19:56
Copy link
Member

@wifelette wifelette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So excited to ship this!

@wifelette
Copy link
Member

Annnd... don't merge just yet :p I want @MelSumner to take a look but also @jeffdaley is going to add a commit with some tweaks we discussed.

@jeffdaley
Copy link
Contributor Author

Tertiary logos added to the Guidelines screen and PDF.

One thing I couldn't figure out is how to change the footer link from "Logos" to "Brand Guidelines." My change in the _footer.erb file didn't work.

Also, should we change the file and url from /logos to /brand-guidelines?

@@ -55,30 +55,30 @@
<li role="separator" class="divider"></li> %>
<li><a href="/team">The Team</a></li>
<li role="separator" class="divider"></li>
<li><a href="/logos">Logos</a></li>
<li><a href="/logos">Brand Guidelines</a></li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, maybe pedantic- "Branding" instead of "Brand Guidelines" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that. Especially since we have "community guidelines."

@MelSumner
Copy link
Contributor

MelSumner commented Jun 2, 2018

@jeffdaley the footer changes aren't showing up because the footer is coming from ember-styleguide - @locks can you confirm?

@sivakumar-kailasam
Copy link
Member

The middleman parts of the website in this repo uses https://github.com/ember-learn/glimmer-styleguide. Everything else uses https://github.com/ember-learn/ember-styleguide

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants