Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Home page updates #3415

Merged
merged 4 commits into from
Jun 19, 2018
Merged

Home page updates #3415

merged 4 commits into from
Jun 19, 2018

Conversation

MelSumner
Copy link
Contributor

What it does

If merged, this PR will implement the following:

  • updates vertical spacing on contribute call to action above footer
  • adds "buy ember gear" in addition to "donate" button
  • fixes the issue where the handlebars feature text started higher than the other text (I would have done a more elegant job at fixing this if we weren't emberizing the website this week)

@MelSumner MelSumner requested review from wifelette and a team June 18, 2018 23:22
@locks locks temporarily deployed to ember-website-staging-pr-3415 June 18, 2018 23:23 Inactive
Copy link
Member

@wifelette wifelette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think something in this or a recent PR re-introduced the old bug where the text on buttons was skewed to the top instead of perfectly centered.

<div class="about__listing-button-group">
<div class="about__listing-button">
<a class="ember-button ember-button--centered" href="https://devswag.com/products/ember-js-tshirt">
Buy Ember Gear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the "buy Ember gear" button link here, instead of to a specific item?

@MelSumner MelSumner dismissed wifelette’s stale review June 19, 2018 15:21

I made the requested change

@MelSumner MelSumner merged commit 121266b into master Jun 19, 2018
@MelSumner MelSumner deleted the feature/home-page-update_061818 branch June 19, 2018 17:37
@wifelette
Copy link
Member

Thanks @MelSumner!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants