Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Uninstall task fails gracefully when given packages are not found #70

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi
Copy link
Contributor Author

So when I run it as:

pnpm dlx ember-cli@latest init -b github:MichalBryxi/app-blueprint#abb5234a33cf0ec7473d3b59b7f12765e014b66a --pnpm --name winds-mobi-client-web

I get quite a promising result:

🚧  Installing packages... This might take a couple of minutes.
pnpm: Installed @embroider/core@unstable, @embroider/vite@unstable and 5 other packages

🚧  Installing packages... This might take a couple of minutes.
pnpm: Uninstalled ember-fetch

🚧  Installing packages... This might take a couple of minutes.
pnpm: Uninstalled broccoli-asset-rev

🚧  Installing packages... This might take a couple of minutes.
pnpm: Uninstalled ember-cli-app-version

🚧  Installing packages... This might take a couple of minutes.
pnpm: Uninstalled ember-cli-clean-css

🚧  Installing packages... This might take a couple of minutes.
pnpm: Uninstalled ember-cli-dependency-checker

🚧  Installing packages... This might take a couple of minutes.
Could not uninstall ember-cli-sri

🚧  Installing packages... This might take a couple of minutes.
Could not uninstall ember-cli-terser

✨  Running "lint:fix" script...

🚧  Installing packages... This might take a couple of minutes.
pnpm: Installed dependencies

🎉  Successfully created project winds-mobi-client-web.
👉  Get started by typing:

  $ cd winds-mobi-client-web
  $ pnpm start

Happy coding!

@MichalBryxi
Copy link
Contributor Author

Might not be the most elegant solution, but ... it works 🤷🏾

@mansona
Copy link
Member

mansona commented Sep 18, 2024

I mean we can worry about elegant later when we are thinking about real official and supported blueprints 😂

@mansona mansona added the bug Something isn't working label Sep 18, 2024
@mansona mansona merged commit 76b0a68 into embroider-build:main Sep 18, 2024
1 of 2 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
@MichalBryxi MichalBryxi deleted the mb/52-uninstall-task branch September 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using ember init to update projects made with this blueprint fails if you're already removed ember-fetch, etc
2 participants