test(new config module): maintain the macro-sample-addon scenario by …

…moving the update of the config on fixture side

tests/addon-template/tests/dummy/app/config/environment.js

@@ -1,4 +1,3 @@
 import loadConfigFromMeta from '@embroider/config-meta-loader';
 
 export default loadConfigFromMeta('dummy');
-// config.APP.fromConfigModule = 'hello new world';

tests/fixtures/macro-sample-addon/tests/dummy/app/config/environment.js

@@ -0,0 +1,6 @@
+import loadConfigFromMeta from '@embroider/config-meta-loader';
+
+let config = loadConfigFromMeta('dummy');
+config.APP.fromConfigModule = 'hello new world';
+
+export default config;

tests/scenarios/macro-test.ts

@@ -213,6 +213,9 @@ function dummyAppScenarioSetup(project: Project) {
       this._super.included.apply(this, arguments);
     },
     contentFor(type, config, contents) {
+      // This if block is used only by macro-sample-addon-classic, which does not build with Embroider.
+      // When building with Embroider, the responsibility for the config is moved to the app.
+      // Therefore, macro-sample-addon scenario defines 'fromConfigModule' differently using fixtures.
       if (type === 'config-module') {
         const originalContents = contents.join('');
         contents.splice(0, contents.length);