Skip to content

Commit

Permalink
now that we push the styles in the correct order, stop reversing them
Browse files Browse the repository at this point in the history
  • Loading branch information
raycohen committed Apr 5, 2024
1 parent 7db1c36 commit e96ddd1
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions packages/compat/src/compat-app-builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -390,21 +390,17 @@ export class CompatAppBuilder {
for (let addon of sortedAddons) {
let implicitScripts = addon.meta[type];
if (implicitScripts) {
let styles = [];
let options = { basedir: addon.root };
for (let mod of implicitScripts) {
if (type === 'implicit-styles') {
// exclude engines because they will handle their own css importation
if (!addon.isLazyEngine()) {
styles.push(resolve.sync(mod, options));
result.push(resolve.sync(mod, options));
}
} else {
result.push(resolve.sync(mod, options));
}
}
if (styles.length) {
result = [...styles, ...result];
}
}
}
return result;
Expand Down Expand Up @@ -581,8 +577,7 @@ export class CompatAppBuilder {
if (!asset) {
let implicitStyles = this.impliedAssets('implicit-styles', application);
if (implicitStyles.length > 0) {
// we reverse because we want the synthetic vendor style at the top
asset = new ConcatenatedAsset('assets/vendor.css', implicitStyles.reverse(), this.resolvableExtensionsPattern);
asset = new ConcatenatedAsset('assets/vendor.css', implicitStyles, this.resolvableExtensionsPattern);
prepared.set(asset.relativePath, asset);
}
}
Expand Down

0 comments on commit e96ddd1

Please sign in to comment.