Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of deprecated Ember global in compat-adapters #779

Closed
sandydoo opened this issue Apr 27, 2021 · 0 comments · Fixed by #784
Closed

Use of deprecated Ember global in compat-adapters #779

sandydoo opened this issue Apr 27, 2021 · 0 comments · Fixed by #784

Comments

@sandydoo
Copy link
Contributor

sandydoo commented Apr 27, 2021

The compat-adapter for ember-inflector checks for Ember.ENV.EXTEND_PROTOTYPES. As of v3.27, accessing the Ember global throws a deprecation notice.

if (Ember.ENV.EXTEND_PROTOTYPES === true || Ember.ENV.EXTEND_PROTOTYPES.String) {

Proposed solution

Replace Ember.ENV with EmberENV.

I assume the use of the global after this check is fine for 1. backwards compatibility reasons 2. why are you extending prototypes in a modern app.

Steps to reproduce

Run ember new with [email protected] and inspect the console. The errors before boot should come from ember-inflector/make-configurable.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant