template-tag-codemod #2226
Merged
template-tag-codemod #2226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings template-tag codemod support onto
main, with a simplified implementation that can rely on #2221.npx @embroider/template-tag-codemod@unstable --helpshould show how to use it.There are probably features from @void-mAlex's earlier implementation that need to get forwarded ported here (like the customized naming capabilities).
The codemod covers both components and route templates (with a flag to use either ember-route-template addon or the native support that has landed in ember-source 6.3.0-alpha.3).
It does not yet cover inline templates, but that can be a reasonable small followup.
(I published an alpha by hand, but it doesn't work right because we also need it pointing at the other unstable embroider packages in its dependencies. The unstable publish from GitHub actions will do it correctly.)