Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need for --single-package #19

Closed
mansona opened this issue Nov 23, 2023 · 1 comment
Closed

Remove the need for --single-package #19

mansona opened this issue Nov 23, 2023 · 1 comment
Labels
pre-1.0

Comments

@mansona
Copy link
Member

mansona commented Nov 23, 2023

I added a hack in #5 that worked around the fact that this was originally designed to work with a monorepo. it's a totally unnecessary command since we can probably figure out if we're in a monorepo automatically

We should remove the need for this command before 1.0
This was referenced Nov 26, 2023
Merged
Merged
@mansona mansona mentioned this issue Dec 12, 2023
Merged
NullVoxPopuli added a commit to ember-tooling/ember-eslint-parser that referenced this issue Dec 18, 2023
@NullVoxPopuli
This wouldn't be necessary if embroider-build/release-plan#19 was fix…
fe6a6d2 
…ed 🙈
@NullVoxPopuli NullVoxPopuli mentioned this issue Dec 18, 2023
Merged
NullVoxPopuli added a commit to universal-ember/kolay that referenced this issue Dec 26, 2023
@NullVoxPopuli
Add --singlePackage and use action-setup-pnpm instead of defaults, See:
d58a4c6 
embroider-build/release-plan#19
NullVoxPopuli added a commit to starbeamjs/dev-compile that referenced this issue Jan 4, 2024
@NullVoxPopuli
Add --singlePackage, use action-setup-pnpm, and set explicit permissi…
c760360 
…ons. See: embroider-build/release-plan#19
@mansona
Copy link
Member Author

mansona commented Feb 16, 2024

I'm pretty sure we don't need this since #47 so I'm going to close the issue 👍

@mansona mansona closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pre-1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mansona