Rewrite with Appache Commons Net

embulk · Jan 10, 2025 · f765294 · f765294
1 parent ab65dbb
commit f765294
Show file tree

Hide file tree

Showing 5 changed files with 140 additions and 192 deletions.
diff --git a/README.md b/README.md
@@ -103,7 +103,7 @@ in:
 ## Build
 
 ```
-$ ./gradlew embulk-input-ftp:gem
+$ ./gradlew gem
 ```
 
 ## Release

diff --git a/build.gradle b/build.gradle
@@ -35,7 +35,7 @@ dependencies {
     compileOnly "org.embulk:embulk-api:0.10.19"
     compileOnly "org.embulk:embulk-spi:0.10.19"
 
-    compile("org.embulk:embulk-util-config:0.3.1") {
+    implementation("org.embulk:embulk-util-config:0.3.1") {
         // They conflict with embulk-core. They are once excluded here,
         // and added explicitly with versions exactly the same with embulk-core:0.10.19.
         exclude group: "com.fasterxml.jackson.core", module: "jackson-annotations"
@@ -47,24 +47,25 @@ dependencies {
 
     // They are once excluded from transitive dependencies of other dependencies,
     // and added explicitly with versions exactly the same with embulk-core:0.10.19.
-    compile "com.fasterxml.jackson.core:jackson-annotations:2.6.7"
-    compile "com.fasterxml.jackson.core:jackson-core:2.6.7"
-    compile "com.fasterxml.jackson.core:jackson-databind:2.6.7"
-    compile "com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.6.7"
-    compile "javax.validation:validation-api:1.1.0.Final"
-
-    compile "org.embulk:embulk-util-ssl:0.3.0"
-    compile files("${project.rootDir}/libs/ftp4j-1.7.2.jar")
-    compile "org.bouncycastle:bcpkix-jdk15on:1.52"
-
-    compile "org.embulk:embulk-util-file:0.1.3"
-    compile "org.embulk:embulk-util-retryhelper:0.8.2"
-
-    testCompile "junit:junit:4.13.2"
-    testCompile "org.embulk:embulk-core:0.10.19"
-    testCompile "org.embulk:embulk-core:0.10.19:tests"
-    testCompile "org.embulk:embulk-standards:0.10.19"
-    testCompile "org.embulk:embulk-deps:0.10.19"
+    implementation "com.fasterxml.jackson.core:jackson-annotations:2.6.7"
+    implementation "com.fasterxml.jackson.core:jackson-core:2.6.7"
+    implementation "com.fasterxml.jackson.core:jackson-databind:2.6.7"
+    implementation "com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.6.7"
+    implementation "javax.validation:validation-api:1.1.0.Final"
+
+    implementation "org.embulk:embulk-util-ssl:0.3.0"
+    implementation "commons-net:commons-net:3.11.1"
+    implementation files("${project.rootDir}/libs/ftp4j-1.7.2.jar")
+    implementation "org.bouncycastle:bcpkix-jdk15on:1.52"
+
+    implementation "org.embulk:embulk-util-file:0.1.3"
+    implementation "org.embulk:embulk-util-retryhelper:0.8.2"
+
+    testImplementation "junit:junit:4.13.2"
+    testImplementation "org.embulk:embulk-core:0.10.19"
+    testImplementation "org.embulk:embulk-core:0.10.19:tests"
+    testImplementation "org.embulk:embulk-standards:0.10.19"
+    testImplementation "org.embulk:embulk-deps:0.10.19"
 }
 
 embulkPlugin {

diff --git a/gradle/dependency-locks/compileClasspath.lockfile b/gradle/dependency-locks/compileClasspath.lockfile
@@ -5,6 +5,7 @@ com.fasterxml.jackson.core:jackson-annotations:2.6.7
 com.fasterxml.jackson.core:jackson-core:2.6.7
 com.fasterxml.jackson.core:jackson-databind:2.6.7
 com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.6.7
+commons-net:commons-net:3.11.1
 javax.validation:validation-api:1.1.0.Final
 org.bouncycastle:bcpkix-jdk15on:1.52
 org.bouncycastle:bcprov-jdk15on:1.52

diff --git a/gradle/dependency-locks/runtimeClasspath.lockfile b/gradle/dependency-locks/runtimeClasspath.lockfile
@@ -5,6 +5,7 @@ com.fasterxml.jackson.core:jackson-annotations:2.6.7
 com.fasterxml.jackson.core:jackson-core:2.6.7
 com.fasterxml.jackson.core:jackson-databind:2.6.7
 com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.6.7
+commons-net:commons-net:3.11.1
 javax.validation:validation-api:1.1.0.Final
 org.bouncycastle:bcpkix-jdk15on:1.52
 org.bouncycastle:bcprov-jdk15on:1.52