Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use second as timetout setting instead of milli second #18

Merged
merged 1 commit into from
Sep 26, 2016

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Sep 26, 2016

Current code intend to use 600 sec as default timeout value.
But actual behavior is 600 msec.

Second parameter of SftpFileSystemConfigBuilder.setTimeout() allows msec, it's not a sec.

SftpFileSystemConfigBuilder.setTimeout(FileSystemOptions opts, Integer timeout)

  • Parameters:
    • opts - The FileSystem options.
    • timeout - The timeout in milliseconds.

https://commons.apache.org/proper/commons-vfs/apidocs/org/apache/commons/vfs2/provider/sftp/SftpFileSystemConfigBuilder.html#setTimeout

Copy link

@uu59 uu59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakama sakama merged commit a396fd7 into master Sep 26, 2016
@sakama sakama deleted the fix-timeout-setting branch September 26, 2016 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants