Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non existent last_path in sftp #28

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

trung-huynh
Copy link
Contributor

In the previous version, if the last_past does not exist in sftp server, the plugin can not load any files and will lead the confusion whether folder contains nothing or not.

The fix will resolve the last_path only when it exists in sftp server and warning in case it does not exist.

Copy link
Contributor

@sakama sakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trung-huynh trung-huynh merged commit 8cd5d33 into embulk:master Mar 12, 2018
@trung-huynh trung-huynh deleted the fix-non-existent-last-path branch March 12, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants