Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build with the "org.embulk.embulk-plugins" Gradle plugin #42

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Build with the "org.embulk.embulk-plugins" Gradle plugin #42

merged 1 commit into from
Feb 14, 2020

Conversation

dmikurube
Copy link
Member

Along with that,

  • Upgrade the Gradle wrapper to use Gradle 6.1.1
  • Upgrade the Bintray Gradle plugin to 1.8.4 (latest)
  • Upgrade depending embulk-core to 0.9.23 (latest)
  • Set JavaCompile option for deprecation and unchecked
  • Test with GitHub Actions, instead of Travis-CI

@dmikurube
Build with the "org.embulk.embulk-plugins" Gradle plugin
ca59b47 
Along with that,
* Upgrade the Gradle wrapper to use Gradle 6.1.1
* Upgrade the Bintray Gradle plugin to 1.8.4 (latest)
* Upgrade depending embulk-core to 0.9.23 (latest)
* Set JavaCompile option for deprecation and unchecked
* Test with GitHub Actions, instead of Travis-CI
@dmikurube dmikurube requested a review from sakama February 13, 2020 15:16
trung-huynh
trung-huynh approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trung-huynh trung-huynh requested a review from ylzen February 14, 2020 03:27
sakama
sakama approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@sakama sakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakama sakama merged commit b78905f into master Feb 14, 2020
@sakama sakama deleted the build-with-embulk-plugins-gradle-plugin branch February 14, 2020 05:19
@dmikurube dmikurube requested review from sakama and removed request for ylzen February 14, 2020 05:25
@dmikurube
Copy link
Member Author

Ah, I mis-operated in the reviewers box...

@sakama
Copy link
Contributor

sakama commented Feb 14, 2020

Pushed to RubyGems and Bintray
https://rubygems.org/gems/embulk-input-sftp/versions/0.3.3-java
https://bintray.com/embulk-input-sftp/maven/embulk-input-sftp/0.3.3

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube mentioned this pull request Feb 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung-huynh trung-huynh trung-huynh approved these changes

@sakama sakama Awaiting requested review from sakama

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmikurube @sakama @trung-huynh