Disable remote temporary file rename logic

embulk · Dec 21, 2017 · af09b1c · af09b1c
1 parent 41ceeff
commit af09b1c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/src/main/java/org/embulk/output/sftp/SftpFileOutput.java b/src/main/java/org/embulk/output/sftp/SftpFileOutput.java
@@ -84,7 +84,12 @@ public void finish()
         closeCurrentFile();
         String fileName = getOutputFilePath();
         String temporaryFileName = fileName + temporaryFileSuffix;
-        sftpUtils.uploadFile(tempFile, temporaryFileName);
+        /*
+          #37 causes permission failure while renaming remote file.
+          https://github.com/embulk/embulk-output-sftp/issues/40
+         */
+        //sftpUtils.uploadFile(tempFile, temporaryFileName);
+        sftpUtils.uploadFile(tempFile, fileName);
 
         Map<String, String> executedFiles = new HashMap<>();
         executedFiles.put("temporary_filename", temporaryFileName);

diff --git a/src/main/java/org/embulk/output/sftp/SftpFileOutputPlugin.java b/src/main/java/org/embulk/output/sftp/SftpFileOutputPlugin.java
@@ -99,17 +99,21 @@ public void cleanup(TaskSource taskSource,
             int taskCount,
             List<TaskReport> successTaskReports)
     {
-        SftpUtils sftpUtils = new SftpUtils(taskSource.loadTask(PluginTask.class));
-        for (TaskReport report : successTaskReports) {
-            List<Map<String, String>> moveFileList = report.get(List.class, "file_list");
-            for (Map<String, String> pairFiles : moveFileList) {
-                String temporaryFileName = pairFiles.get("temporary_filename");
-                String realFileName = pairFiles.get("real_filename");
-
-                sftpUtils.renameFile(temporaryFileName, realFileName);
-            }
-        }
-        sftpUtils.close();
+        /*
+          #37 causes permission failure while renaming remote file.
+          https://github.com/embulk/embulk-output-sftp/issues/40
+         */
+//        SftpUtils sftpUtils = new SftpUtils(taskSource.loadTask(PluginTask.class));
+//        for (TaskReport report : successTaskReports) {
+//            List<Map<String, String>> moveFileList = report.get(List.class, "file_list");
+//            for (Map<String, String> pairFiles : moveFileList) {
+//                String temporaryFileName = pairFiles.get("temporary_filename");
+//                String realFileName = pairFiles.get("real_filename");
+//
+//                sftpUtils.renameFile(temporaryFileName, realFileName);
+//            }
+//        }
+//        sftpUtils.close();
     }
 
     @Override