Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide password in the log #25

Merged
merged 1 commit into from
Mar 9, 2017
Merged

Hide password in the log #25

merged 1 commit into from
Mar 9, 2017

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Mar 9, 2017

Current implementation is showing password in the log.

parent directory sftp://sftp-user:[email protected]/home/sftp-user exists there
Could not create folder "sftp://sftp-user:[email protected]/home/sftp-user"

I want to hide for the security reason and changed logging logic to hide them.

parent directory sftp://ec2-user:***@example.com/home/ec2-user exists there
Could not create folder "sftp://sftp-user:***@example.com/home/ec2-user2"

FileObject.getPublicURIString() is already used at other part.

@civitaspo
Copy link
Member

Looks good for me.

@civitaspo civitaspo merged commit 2af90e0 into embulk:master Mar 9, 2017
@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 72.455% when pulling f94e428 on sakama:mask_password into 7834176 on civitaspo:master.

@sakama sakama deleted the mask_password branch March 9, 2017 05:07
@sakama
Copy link
Contributor Author

sakama commented Mar 9, 2017

Thank you!

@civitaspo
Copy link
Member

shipped \w https://rubygems.org/gems/embulk-output-sftp/versions/0.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants