Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: Increment fileIndex after complete uploadFile #35

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Fix bug: Increment fileIndex after complete uploadFile #35

merged 1 commit into from
Jul 8, 2017

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Jul 7, 2017 •
edited
Loading

Current implementation don't increment fileIndex. This don't affect when each task only output 1 file.
However, file name will be conflicted when task generates multiple files.

I added increment logic at SftpFileOutput.finish instead of SftpFileOutput.nextFile since SftpFileOutput class set fileIndex=0 when initialized.

@sakama
Copy link
Contributor Author

sakama commented Jul 7, 2017

@instcode Could you take a look?

instcode
instcode approved these changes Jul 8, 2017
View reviewed changes
Copy link
Contributor

@instcode instcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakama sakama merged commit 37a6a57 into master Jul 8, 2017
@sakama sakama deleted the add-file-index-increment branch July 8, 2017 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@instcode instcode instcode approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @instcode