Implement original SFTP provider for Apache Commons VFS2 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakama
force-pushed
the
implement-original-sftp-provider
branch
2 times, most recently
from
4dd03c8 to
6af7c8a
Compare
sakama
force-pushed
the
implement-original-sftp-provider
branch
from
6af7c8a to
af1819a
Compare
sakama
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #43
I implemented original SFTP provider based on
org.apache.commons.vfs2.provider.sftp/*to disable permission check logic before renaming remote files.Apache Commons VFS2 is checking parent directory's permission.
This works if SFTP account can execute command over SSH. But doesn't works when command execution isn't permitted. #40
https://issues.apache.org/jira/browse/VFS-590
src/main/java/org/embulk/output/sftp/provider/*implementation is almost same with SFTP provider in Apache Commons VFS2.Main change is af1819a
Additionally, I changed
org.apache.commons.vfs2.impl.StandardFileSystemManagertoorg.apache.commons.vfs2.impl.DefaultFileSystemManager.I faced ClassLoader problem and can't pass my original
providers.xmltoStandardFileSystemmanager.We can remove these files when VFS-590 is solved.