Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java.util.regex.Pattern for host name validation #49

Merged
merged 1 commit into from
May 7, 2018
Merged

Use java.util.regex.Pattern for host name validation #49

merged 1 commit into from
May 7, 2018

Conversation

sakama
Copy link
Contributor

@sakama sakama commented May 7, 2018 •
edited
Loading

Follow up for #48 This is minor fix.
String.contains("%s") didn't works properly.
I used java.util.regex.Pattern instead.

@sakama sakama requested a review from trung-huynh May 7, 2018 07:18
trung-huynh
trung-huynh approved these changes May 7, 2018
View reviewed changes
Copy link

@trung-huynh trung-huynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sakama sakama merged commit fb7025f into master May 7, 2018
@sakama sakama deleted the fix-validation-for-test branch May 7, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trung-huynh trung-huynh trung-huynh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @trung-huynh