Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved logic that detects exception is retryable or not #52

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Improved logic that detects exception is retryable or not #52

merged 1 commit into from
Oct 23, 2018

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Oct 23, 2018

"Auth fail" is better than "USERAUTH fail".

@sakama sakama force-pushed the improve-retry-logic branch from 49b0958 to 36f70b3 Compare October 23, 2018 08:21
@sakama sakama force-pushed the improve-retry-logic branch from 36f70b3 to d7c9d67 Compare October 23, 2018 08:26
@sakama sakama requested a review from tvhung83 October 23, 2018 08:31
tvhung83
tvhung83 approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@tvhung83 tvhung83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix! 👍

@sakama sakama merged commit aea0cf3 into master Oct 23, 2018
@sakama sakama deleted the improve-retry-logic branch October 23, 2018 08:36
@sakama sakama mentioned this pull request Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvhung83 tvhung83 tvhung83 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @tvhung83