Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling #9

Merged
merged 3 commits into from
Mar 4, 2016
Merged

Fix error handling #9

merged 3 commits into from
Mar 4, 2016

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Mar 4, 2016

I fixed error handlings and so on.

  • throw ConfigException instead of RuntimeException
  • Release resource at finally block
  • Return Exec.newTaskReport() when close() method is called

@sakama
Copy link
Contributor Author

sakama commented Mar 4, 2016

CI failed. This failure will be fixed by #7.

@sakama
Copy link
Contributor Author

sakama commented Mar 4, 2016

#7 was merged. And I merged these changes.

@civitaspo
Copy link
Member

LGTM!

civitaspo added a commit that referenced this pull request Mar 4, 2016
@civitaspo
Merge pull request #9 from sakama/fix-error-handling
b447f02 
Fix error handling
@civitaspo civitaspo merged commit b447f02 into embulk:master Mar 4, 2016
@sakama sakama deleted the fix-error-handling branch March 4, 2016 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @civitaspo