Skip to content

Commit

Permalink
new flagEngine deploy + git typo
Browse files Browse the repository at this point in the history
  • Loading branch information
eddow committed Jun 8, 2024
1 parent 8c66e7d commit f1e76ba
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@
*.config.js
*.config.json
.gitignore
/.svelte-kit
package-lock.json
/.svelte-kit
3 changes: 2 additions & 1 deletion docs/bonus.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The library takes in consideration two cases:
- On systems who support flags emojis, flags will just be this, a 2~3 unicode characters that form the emoji
- On windows, the library `flag-icons` will be downloaded dynamically from [cdnjs.com](https://cdnjs.com/libraries/flag-icon-css) (~28k) and `localeFlag` will return a `<span...` string. This is done transparently client-side

Therefore,
Therefore,

Two `exceptions` lists are kept (one for emojis, one for flag class name): `flagEmojiExceptions` and `flagClassExceptions`. These are for languages who are not bound to a country (by default, it only contains `en` -> `gb`)

Expand Down Expand Up @@ -42,6 +42,7 @@ In order to retrieve the engine name, when transferring data to "client" (SSR/br
### But ... why ?

Why asking the server to tell the client if it runs on windows ? It's indeed the only way to solve two somehow contradictory issues :

- Make sure no extra download is done. Each Kb file to be downloaded is latency on mobile app
- Make sure there is no "blinking" on load (when the generated page differs from the `onMount` result), even on windows machines

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "omni18n",
"version": "1.1.12",
"version": "1.1.14",
"exports": {
".": {
"browser": {
Expand All @@ -26,7 +26,7 @@
"./ts/s-a": "./src/s-a.ts"
},
"bin": {
"extractLocales": "./bin/extractLocales.js"
"extractLocales": "./bin/extractLocales.mjs"
},
"description": "",
"type": "module",
Expand Down

0 comments on commit f1e76ba

Please sign in to comment.