Merge pull request #367 from escobar-felipe/feat/deferscript-id

feat: add support for setting an id to the dynamically created script…
emilhe · Dec 17, 2024 · 67d0191 · 67d0191
2 parents 57c350d + 28cc107
commit 67d0191
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/lib/components/DeferScript.react.js b/src/lib/components/DeferScript.react.js
@@ -8,13 +8,18 @@ import PropTypes from 'prop-types';
 export default class DeferScript extends React.Component {
 
   componentDidMount () {
-    if (this.props.src) {
+    const { src, id } = this.props;
+    if (src) {
       const {src} = this.props;
       const script = document.createElement('script');
 
       script.src = src;
       script.defer = true;
 
+      if (id) {
+        script.id = id;
+      }
+
       document.body.appendChild(script);
       }
     }

diff --git a/tests/components/defer_script.py b/tests/components/defer_script.py
@@ -13,7 +13,7 @@
             style={"maxWidth": "100%"},
             **{"data-mxgraph": unescape(mxgraph)},
         ),
-        DeferScript(src="https://viewer.diagrams.net/js/viewer-static.min.js"),
+        DeferScript(id="viewer", src="https://viewer.diagrams.net/js/viewer-static.min.js"),
     ]
 )