Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_proc_address in CreationContext #4145

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add get_proc_address in CreationContext #4145

merged 2 commits into from
Mar 13, 2024

Conversation

Chaojimengnan
Copy link
Contributor

@Chaojimengnan Chaojimengnan marked this pull request as draft March 10, 2024 12:35
@Chaojimengnan Chaojimengnan marked this pull request as ready for review March 10, 2024 14:09
@emilk emilk added the eframe Relates to epi and eframe label Mar 12, 2024
@emilk
Copy link
Owner

emilk commented Mar 12, 2024

needs fix for web build

@Chaojimengnan Chaojimengnan requested a review from emilk March 12, 2024 16:34
@emilk emilk merged commit 47fbce6 into emilk:master Mar 13, 2024
19 checks passed
hacknus pushed a commit to hacknus/egui that referenced this pull request Oct 30, 2024
@Chaojimengnan @hacknus
Add get_proc_address in CreationContext (emilk#4145)
8b992f4 
<!--
Please read the "Making a PR" section of
[`CONTRIBUTING.md`](https://github.com/emilk/egui/blob/master/CONTRIBUTING.md)
before opening a Pull Request!

* Keep your PR:s small and focused.
* The PR title is what ends up in the changelog, so make it descriptive!
* If applicable, add a screenshot or gif.
* If it is a non-trivial addition, consider adding a demo for it to
`egui_demo_lib`, or a new example.
* Do NOT open PR:s from your `master` branch, as that makes it hard for
maintainers to add commits to your PR.
* Remember to run `cargo fmt` and `cargo cranky`.
* Open the PR as a draft until you have self-reviewed it and run
`./scripts/check.sh`.
* When you have addressed a PR comment, mark it as resolved.

Please be patient! I will review your PR, but my time is limited!
-->

* Closes <emilk#4144>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk Awaiting requested review from emilk

Assignees
No one assigned
Labels
eframe Relates to epi and eframe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide get_proc_address function in eframe::CreationContext
2 participants
@Chaojimengnan @emilk