egui_glium: run app code outside event loop to fix file dialogs #631
+83
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously app code was run from within the event loop which lead to file dialogs (e.g. using nfd2) to hang (see rust-windowing/winit#1779) Now egui_glium polls for events and then runs the app code.
This was referenced Aug 19, 2021
This was referenced Aug 23, 2021
mankinskin
pushed a commit
to mankinskin/egui
that referenced
this pull request
Sep 29, 2021
…k#631) Previously app code was run from within the event loop which lead to file dialogs (e.g. using nfd2) to hang (see rust-windowing/winit#1779) Now egui_glium polls for events and then runs the app code.
emilk
added a commit
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously app code was run from within the event loop which lead to native dialogs (e.g. using
nfd2orrfd) to hang (see rust-windowing/winit#1779).Now egui_glium polls for events and then runs the app code.