Allow setting a line's fill area's alpha channel #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I'm trying to achieve stacked plot lines and came across Line::fill, which does exactly what I want. The only problem with drawing the fill area is that a user doesn't have control over the alpha channel. As a result, having multiple fill areas within a single plot causes the colors to blend, which is undesired in my case. See the images below:
Current:
Desired:
This change adds
Line::fill_alpha, which allows a user to explicitly set the alpha channel used for drawing the fill area. The default value forfill_alpharemains the same as before, causing this PR to not be a breaking change.